Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc how to using iceoryx as 3rdparty dependency #2246

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Add doc how to using iceoryx as 3rdparty dependency #2246

merged 1 commit into from
Apr 6, 2024

Conversation

phongt
Copy link
Contributor

@phongt phongt commented Apr 6, 2024 •
edited by elBoberido
Loading

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov Codecov
Copy link

codecov bot commented Apr 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.52%. Comparing base (515bcf6) to head (a084559).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2246   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files         431      431           
  Lines       16631    16631           
  Branches     2333     2333           
=======================================
  Hits        13059    13059           
  Misses       2707     2707           
  Partials      865      865
Flag Coverage Δ
unittests 78.31% <ø> (ø)
unittests_timing 15.32% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

elBoberido
elBoberido approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much :)

@elBoberido elBoberido added the documentation Improvements or additions to documentation label Apr 6, 2024
@elBoberido elBoberido merged commit 67223fe into eclipse-iceoryx:master Apr 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elBoberido elBoberido elBoberido approved these changes

Assignees

@phongt phongt

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] bazel http_archive iceoryx as 3rdparty dependency report errors.
2 participants
@phongt @elBoberido